[PATCH] build-locale-archive sometimes created empty archives

[Mike FABIAN]

"Carlos O'Donell" <carlos at redhat.com> さんはかきました:

> On 09/17/2015 10:01 AM, Mike FABIAN wrote:
>> build-locale-archive sometimes created empty archives
>
> How did you test this?

> Did you try the resulting binary and verify it still works?

I installed the rpms I built with mockbuild for F23 on
Fedora-Workstation-netinst-x86_64-23_Beta.iso in qemu-kvm
and tried 

sudo rpm -Uhv -D "_install_langs en_US" glibc-common-2.22-2.fc23.x86_64.rpm --force

with various different values for _install_langs and it created
the locale-archive as expected.

I also tried the binary directly doing something like:

sudo cp /usr/lib/locale/locale-archive /usr/lib/locale/locale-archive.tmpl
/usr/sbin/build-locale-archive  --install-langs en_US

This worked fine with *both* the old *and* the new binary.

(I guess the old binary works accidentally).

> I imagine that if you ran the old binary through valgrind it would
> raise a failure, but the new binary would not. Did you try that?

I did not check that, trying it now ...

-- 
Mike FABIAN <mfabian at redhat.com>
☏ Office: +49-69-365051027, internal 8875027
睡眠不足はいい仕事の敵だ。