[Fedora-haskell-list] [Bug 651613] Review Request: haddock - Haskell documentation tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651613

--- Comment #6 from Jens Petersen <petersen at redhat.com> 2011-01-17 07:35:38 EST ---
Likewise, sorry. :)


Here is the review:

 +:ok, NA: not applicable, !: needs attention

MUST Items:
[+] MUST: rpmlint output

haddock.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell,
Skellum
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
ghc-haddock.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-haddock.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
ghc-haddock-devel.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
ghc-haddock-prof.x86_64: E: devel-dependency ghc-haddock-devel
ghc-haddock-prof.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-haddock-prof.x86_64: W: no-documentation
ghc-haddock-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.3/haddock-2.7.2/libHShaddock-2.7.2_p.a
1 packages and 0 specfiles checked; 1 errors, 3 warnings.
haddock.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell,
Skellum
haddock.x86_64: W: no-manual-page-for-binary haddock-2.7.2
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

These are ok.

[+] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[!] MUST: Licensing Guidelines

Need license in ghc-haddock too.

Actually this is kind of a ghc-rpm-macros bug/rfe,
so I will see if I can improve it.

[+] MUST: License field in the package spec file must match actual license.

BSD

[+] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release

7b4a8d47ef01d06dc778e0237bafbf1b  haddock-2.7.2.tar.gz

[+] MUST: must successfully compile and build into binary rpms on one main arch

http://koji.fedoraproject.org/koji/taskinfo?taskID=2725798 (f14 build since ghc
is broken in rawhide right now)

[+] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations
[NA] MUST: packages which store shared library files in the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Every %files section must
include a %defattr(...) line.
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissable content.
[NA] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[NA] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[NA] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[NA] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.

Once we have a copy of the license on the shared lib package
I am happy to approve this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.