[Fedora-haskell-list] [Bug 662258] Review Request: ghc-pcre-light - A regex library for Perl 5 compatible regular expressions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662258

Andrew McNabb <amcnabb at mcnabbs.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amcnabb at mcnabbs.org

--- Comment #1 from Andrew McNabb <amcnabb at mcnabbs.org> 2011-01-26 13:54:31 EST ---
1) These errors from rpmlint should be fixed if possible:

ghc-pcre-light-prof.x86_64: E: devel-dependency ghc-pcre-light-devel
ghc-pcre-light-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.3/pcre-light-0.4/libHSpcre-light-0.4_p.a

2) There shouldn't be common_summary, common_description, and ghc_pkg_c_deps
macros since these are only used once.  The ghc_pkg_deps line should be removed
completely because the macro is undefined.

3) I noticed that there are two options for conditional builds: shared and
hscolour.  Can you confirm that these are desirable?  In other words, could you
add a comment to the spec file describing why someone might choose to use these
options?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.