[Bug 829727] Review Request: ghc-lazysmallcheck - Library for demand driven testing of Haskell programs

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=829727

Lakshmi Narasimhan <lakshminaras2002 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #2 from Lakshmi Narasimhan <lakshminaras2002 at gmail.com> ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint  -i ghc-lazysmallcheck-0.6-1.fc16.src.rpm
ghc-lazysmallcheck-0.6-1.fc16.x86_64.rpm
ghc-lazysmallcheck-devel-0.6-1.fc16.x86_64.rpm ../ghc-lazysmallcheck.spec 
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        License - OK
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Build Requires list - OK
        API documentation - OK, in devel packages

[+]MUST : Summary and description
[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
License is BSD
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
LICENSE file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.
md5sum lazysmallcheck-0.6.tar.gz 
9a1f815146ac7934518154f1f3a3620c  lazysmallcheck-0.6.tar.gz

md5sum ghc-lazysmallcheck-0.6-1.fc16.src/lazysmallcheck-0.6.tar.gz 
9a1f815146ac7934518154f1f3a3620c 
ghc-lazysmallcheck-0.6-1.fc16.src/lazysmallcheck-0.6.tar.gz

[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on x86_64
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR.
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
rpm -e ghc-lazysmallcheck-0.6-1.fc16.x86_64
error: Failed dependencies:
        ghc(lazysmallcheck-0.6) = f4bafa6be17c01ffed218211055abfce is needed by
(installed) ghc-lazysmallcheck-devel-0.6-1.fc16.x86_64
        ghc-lazysmallcheck = 0.6-1.fc16 is needed by (installed)
ghc-lazysmallcheck-devel-0.6-1.fc16.x86_64
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Loaded Test.LazySmallCheck into ghci. Loads fine.

cabal2spec-diff is OK.

APPROVED.

rpm qi on the devel package gives "A lazysmallcheck library for Haskell" as the
description.
I think it is better to put the  description in %common_description  so that it
is used in both base and devel packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.