[Bug 662259] Review Request: git-annex - Manage files with git, without checking their contents in

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=662259

Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #36 from Jens Petersen <petersen at redhat.com> ---
Sorry for the delay in reviewing.

Here is my review by hand:

Here is the review:

 +:ok, NA: not applicable, !: need attention

MUST Items:
[!] MUST: rpmlint output [1]

Please fix the RPM group for the docs subpackage when importing.

[+] MUST: package named according to Package Naming Guidelines
[+] MUST: spec file name must match base package %{name} [2]
[+] MUST: meet Packaging Guidelines
[+] MUST: Fedora approved license and Licensing Guidelines
[+] MUST: License field in the package spec file must match actual license. [3]
[+] MUST: include license files in %doc if available in source [4]
[+] MUST: The spec file must be written in American English [5] and legible.
[6]
[+] MUST: source md5sum matches upstream release (from upstream URL)

7807387d240e6343853718097e46ec15  git-annex-3.20120522.tar.gz

[+] MUST: successfully compile and build into binary rpms on a primary arch [7]

http://koji.fedoraproject.org/koji/taskinfo?taskID=4153193

[NA] MUST: if necessary use ExcludeArch for other archs [8]
[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations [9]
[NA] MUST: packages which store shared library files in the dynamic linker's
default paths, must call ldconfig in %post and %postun. [10]
[+] MUST: Packages must NOT bundle copies of system libraries. [11]
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review [12]
[+] MUST: A package must own all directories that it creates. [13]
[+] MUST: A package must not contain any duplicate files in the %files listing.
[14]

But I recommend removing the extra GPL file in the docs subpackage

[+] MUST: Permissions on files must be set properly. [15]
[+] MUST: consistently use macros [16]
[+] MUST: The package must contain code, or permissable content. [17]
[+] MUST: Large documentation files should go in a doc subpackage. [18]
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. [18]
[NA] MUST: Header files must be in a -devel package. [19]
[NA] MUST: Static libraries must be in a -static package. [20]
[NA] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package. [19]
[NA] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency [21]
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec. [20]
[NA] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. [22]
[+] MUST: Packages must not own files or directories already owned by other
packages. [23]
[+] MUST: All filenames in rpm packages must be valid UTF-8. [24]

SHOULD Items:
[+] SHOULD: The reviewer should test that the package builds in mock. [27]
[+] SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
[+] SHOULD: your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense.[32]

Package is APPROVED.

But fix the docs subpackage RPM group when importing.

The latest release is now 3.20120611.  It is probably going to be challenging
to keep up with Joey but might be nice to update to the latest release if
possible after importing the srpm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.