[Bug 859032] Review Request: ghc-data-memocombinators - Combinators for building memo tables

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=859032

--- Comment #4 from Lakshmi Narasimhan <lakshminaras2002 at gmail.com> ---
Ok.Thanks

[+]MUST: rpmlint must be run onevery package. The output should be posted in
the review.
rpmlint  -i ghc-data-memocombinators-0.4.3-1.fc17.x86_64.rpm
ghc-data-memocombinators-devel-0.4.3-1.fc17.x86_64.rpm
ghc-data-memocombinators-0.4.3-1.fc17.src.rpm ../ghc-data-memocombinators.spec 
ghc-data-memocombinators.x86_64: W: spelling-error %description -l en_US
Combinators -> Combinations, Combination, Contaminators
The value of this tag appears to be misspelled. Please double-check.

ghc-data-memocombinators-devel.x86_64: W: spelling-error %description -l en_US
Combinators -> Combinations, Combination, Contaminators
The value of this tag appears to be misspelled. Please double-check.

ghc-data-memocombinators.src: W: spelling-error %description -l en_US
Combinators -> Combinations, Combination, Contaminators
The value of this tag appears to be misspelled. Please double-check.

3 packages and 1 specfiles checked; 0 errors, 3 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        License - OK
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Build Requires list - OK
        Summary and description - OK
        API documentation - OK

[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual
license.
LICENSE is BSD3.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
LICENSE file is included as extra sources obtained from upstream.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
 sha256sum data-memocombinators-0.4.3.tar.gz
ghc-data-memocombinators-0.4.3-1.fc16.src/data-memocombinators-0.4.3.tar.gz 
4cbfdcfaf73674591373097b144f4bc655458c6f3ca6af5c3d7e88cad893fb57 
data-memocombinators-0.4.3.tar.gz
4cbfdcfaf73674591373097b144f4bc655458c6f3ca6af5c3d7e88cad893fb57 
ghc-data-memocombinators-0.4.3-1.fc16.src/data-memocombinators-0.4.3.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on x86_64.
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
        ghc(data-memocombinators-0.4.3) = 3cd7a3ec2af2cd2a9794bcf2e6cf4fed is
needed by (installed) ghc-data-memocombinators-devel-0.4.3-1.fc17.x86_64
        ghc-data-memocombinators = 0.4.3-1.fc17 is needed by (installed)
ghc-data-memocombinators-devel-0.4.3-1.fc17.x86_64
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it. 
[+]SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
Installed the packages. Loaded Data.MemoCombinators into ghci. Loads fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity.

cabal2spec-diff is OK.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.