[Bug 850489] Review Request: ghc-HSH - Haskell HSH library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=850489

Lakshmi Narasimhan <lakshminaras2002 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review+

--- Comment #2 from Lakshmi Narasimhan <lakshminaras2002 at gmail.com> ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint  -i ghc-HSH-2.0.4-1.fc17.src.rpm  ghc-HSH-2.0.4-1.fc17.x86_64.rpm
ghc-HSH-devel-2.0.4-1.fc17.x86_64.rpm ../ghc-HSH.spec 
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        License - OK
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Build Requires list - OK
        Summary and description - OK
        API documentation - OK, in devel package.

[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual
license.
LGPLv2.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
COPYING file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
 sha256sum HSH-2.0.4.tar.gz ghc-HSH-2.0.4-1.fc16.src/HSH-2.0.4.tar.gz 
68a3556e722d91aa2240f3c9c95fa351116af7d138e6d03034e10834eb57b7b5 
HSH-2.0.4.tar.gz
68a3556e722d91aa2240f3c9c95fa351116af7d138e6d03034e10834eb57b7b5 
ghc-HSH-2.0.4-1.fc16.src/HSH-2.0.4.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on x86_64. Links for koji builds on x86 and x86_64 in the review request.
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
API documentation in -devel package.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[NA]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix
(e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must
go in a -devel package.
[+]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[-]SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available. 
[-]SHOULD: The reviewer should test that the package builds in mock. 
[-]SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+]SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
Imported HSH.Command into ghci. Loads fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity.

cabal2spec-diff is OK.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.