[Bug 1008083] Review Request: hoogle - Haskell API Search

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1008083

Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ASSIGNED



--- Comment #4 from Jens Petersen <petersen at redhat.com> ---
Thanks for reviewing.

(In reply to Shakthi Kannan from comment #3)
> - Static libraries in -static or -devel subpackage, providing -devel if
>   present.

I released cabal-rpm-0.8.5 which is now going into updates-testing
which adds a static Provides to the devel subpackage.

>   Note: Package has .a files: ghc-hoogle-devel. Does not provide -static:
> ghc-hoogle-devel.

Note there seems to be a big in fedora-review where it checks
for requires instead provides static: so even after fixing this
it will still show up as a false positive.  I opened a fedora-review
bug with a patch to fix this.  See bug 1012873.

> - Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.
>   Note: Documentation size is 1239040 bytes in 64 files.

It is fairly large but still small compared to the total devel pkg size.
The devel pkg is only about 1.4MB anyway.  So I feel it could be waived.

> [-]: Package is not known to require an ExcludeArch tag.

Actually it excludes armv7hl since conduit is not building with ghc-7.6.3.
It should be able to build on f19 arm I suppose: so maybe I should
restrict the excludes to f20 (and f21 for now).

> Generic:
> [-]: Large data in /usr/share should live in a noarch subpackage if package
> is arched.
>      Note: Arch-ed rpms have a total of 1443840 bytes in /usr/share

This is mostly the large docs: anyway ghc does not support multilib.

I noticed there is a copy of jquery in source data dir
but fortunately it is not packaged (yet).  Hopefully jquery
will be packaged in fedora before we have yesod to enable
the hoogle web app.

> hoogle.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/hoogle-4.2.16/README.txt

Fixing

> hoogle.x86_64: W: no-manual-page-for-binary hoogle
> 4 packages and 0 specfiles checked; 0 errors, 2 warnings.

(The hoogle "manual" http://www.haskell.org/haskellwiki/Hoogle
refers to README.md (in git) as the "manpage".)

> The build is failing on F18:
>  http://koji.fedoraproject.org/koji/taskinfo?taskID=5954875
> "Setup: At least the following dependencies are missing:
> http-types >=0.7"

hoogle-4.2.11 should be able to build with http-types-0.6.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8APIwmHyaO&a=cc_unsubscribe