[Bug 986641] Review Request: ghc-shakespeare-js - Compile-time variable interpolation for Javascript

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=986641

Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(petersen at redhat.c |
                   |om)                         |



--- Comment #4 from Jens Petersen <petersen at redhat.com> ---
(In reply to Sébastien Willmann from comment #3)
>      alson -> also
>      Remove the space before the final dot.
>      Add a dot at the end of the second paragraph.

Okay sure thanks - I will fix those.

See https://github.com/yesodweb/shakespeare/pull/123

> The package seems to contain tests, maybe you can add a check section?

Right, but we don't have hspec packaged in Fedora yet.
In fact we have been kind of "systematically" ignoring
test-frameworks so it is probably about time we started to
package some of them, but I don't think it needs to block
this review. :)

(I am also planning to update to latest version but that
could be done after - it needs an update of shakespeare anyway.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LNE9sCHrio&a=cc_unsubscribe