[Bug 1075605] Review Request: ghc-distributive - Haskell 98 Distributive functors -- Dual to Traversable
bugzilla at redhat.com
bugzilla at redhat.com
Tue Feb 17 08:25:32 UTC 2015
https://bugzilla.redhat.com/show_bug.cgi?id=1075605
Jens Petersen <petersen at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody at fedoraproject.org |petersen at redhat.com
Flags| |fedora-review+
--- Comment #7 from Jens Petersen <petersen at redhat.com> ---
(It might be nice to update it to latest cblrpm.)
I might simplify the Summary to "Distributive functors"
and change the terse description to
"Distributive functors are dual to Traversable."
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 4 files have unknown license. Detailed output of
licensecheck in /home/petersen/pkgreview/1075605-ghc-
distributive/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib64/ghc-7.8.4,
/usr/lib64/ghc-7.8.4/package.conf.d
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/ghc-7.8.4,
/usr/lib64/ghc-7.8.4/package.conf.d
owned by ghc
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Haskell:
[x]: This should never happen
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
http://koji.fedoraproject.org/koji/taskinfo?taskID=8962574
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[-]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Note: Test run failed
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: ghc-distributive-0.4.4-1.fc23.x86_64.rpm
ghc-distributive-devel-0.4.4-1.fc23.x86_64.rpm
ghc-distributive-0.4.4-1.fc23.src.rpm
ghc-distributive.x86_64: W: spelling-error Summary(en_US) functors -> functions
ghc-distributive.x86_64: W: spelling-error %description -l en_US functors ->
functions
ghc-distributive.src: W: spelling-error Summary(en_US) functors -> functions
ghc-distributive.src: W: spelling-error %description -l en_US functors ->
functions
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
Requires
--------
ghc-distributive-devel (rpmlib, GLIBC filtered):
/bin/sh
ghc(distributive-0.4.4-823fa30dcefa22b65bdb69d40ee0ed40)
ghc-compiler
ghc-devel(base-4.7.0.2-cb23b5265b6e147094c0cd9ac819acb1)
ghc-devel(ghc-prim-0.3.1.0-a24f9c14c632d75b683d0f93283aea37)
ghc-devel(tagged-0.7.3-4aece88b76fce3c636457239733a4dfa)
ghc-devel(transformers-0.3.0.0-6458c21515cab7c1cf21e53141557a1c)
ghc-devel(transformers-compat-0.3.3.4-b3647e8665bc927c7a6efb35e8fc69ab)
ghc-distributive(x86-64)
ghc-distributive (rpmlib, GLIBC filtered):
ghc(base-4.7.0.2-cb23b5265b6e147094c0cd9ac819acb1)
ghc(ghc-prim-0.3.1.0-a24f9c14c632d75b683d0f93283aea37)
ghc(tagged-0.7.3-4aece88b76fce3c636457239733a4dfa)
ghc(transformers-0.3.0.0-6458c21515cab7c1cf21e53141557a1c)
ghc(transformers-compat-0.3.3.4-b3647e8665bc927c7a6efb35e8fc69ab)
libHSbase-4.7.0.2-ghc7.8.4.so()(64bit)
libHSghc-prim-0.3.1.0-ghc7.8.4.so()(64bit)
libHSinteger-gmp-0.5.1.0-ghc7.8.4.so()(64bit)
libHStagged-0.7.3-ghc7.8.4.so()(64bit)
libHStransformers-0.3.0.0-ghc7.8.4.so()(64bit)
libHStransformers-compat-0.3.3.4-ghc7.8.4.so()(64bit)
libc.so.6()(64bit)
libgmp.so.10()(64bit)
rtld(GNU_HASH)
Provides
--------
ghc-distributive-devel:
ghc-devel(distributive-0.4.4-823fa30dcefa22b65bdb69d40ee0ed40)
ghc-distributive-devel
ghc-distributive-devel(x86-64)
ghc-distributive-static
ghc-distributive:
ghc(distributive-0.4.4-823fa30dcefa22b65bdb69d40ee0ed40)
ghc-distributive
ghc-distributive(x86-64)
libHSdistributive-0.4.4-ghc7.8.4.so()(64bit)
Unversioned so-files
--------------------
ghc-distributive:
/usr/lib64/ghc-7.8.4/distributive-0.4.4/libHSdistributive-0.4.4-ghc7.8.4.so
Source checksums
----------------
http://hackage.haskell.org/package/distributive-0.4.4/distributive-0.4.4.tar.gz
:
CHECKSUM(SHA256) this package :
82d1f53495fe9c25e4e974825666b4a6232af7452784e145cc04aeb365b25468
CHECKSUM(SHA256) upstream package :
82d1f53495fe9c25e4e974825666b4a6232af7452784e145cc04aeb365b25468
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1075605
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Haskell, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Otherwise looks fine to me.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zxrwntz1Dj&a=cc_unsubscribe
More information about the haskell-devel
mailing list