[Fedora-i18n-bugs] [Bug 488173] Package Review: ibus-table-erbi

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488173


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #2 from Parag AN(पराग) <panemade at gmail.com>  2009-04-03 01:44:03 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1274696
+ rpmlint output for SRPM and for RPM.
ibus-table-erbi.noarch: E: zero-length
/usr/share/doc/ibus-table-erbi-1.1.0.20090402/AUTHORS
==> can be fixed by removing AUTHORS file.

+ source files match upstream url
5b36a300b07cb6eb74be84f74ae63a4b  ibus-table-erbi-1.1.0.20090402.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ibus-table-createdb scriptlet used.
+ file permissions are appropriate.
+ Not a GUI App.  

Suggestions:
1) Drop AUTHORS files from %doc as rpmlint message reported as
ibus-table-erbi.noarch: E: zero-length
/usr/share/doc/ibus-table-erbi-1.1.0.20090402/AUTHORS
2) try adding contents to Changelog file in upstream and add it as %doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.