[Fedora-i18n-bugs] [Bug 226381] Merge Review: ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226381





--- Comment #28 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-04-08 13:26:07 EDT ---
Sorry for delay.
With the scriptlets in your comment 27:

------------------------------------------------------
            (
                iconv -f euc-jp -t utf-8 $i > $i.new \
                    && mv $i.new $i \
                    || rm -f $i.new
            )
------------------------------------------------------
will always exit with 0 (unless "rm -f" fails with some _very_
strange reason) and the latter 
------------------------------------------------------
        if [ $? != 0 ]; then
            iconv -f iso8859-1 -t utf-8 $i > $.new \
                && mv $i.new $i \
                || rm -f $i.new
        fi
------------------------------------------------------
will never be executed. i.e. the first "exit 1" before )
need not be changed, the latter "|| exit 1" has to be
changed to "|| rm -f $i.new" as you wrote.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.