[Fedora-i18n-bugs] [Bug 536737] Review Request: yum-langpacks - langpacks plugin for yum

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=536737


Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org




--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org>  2009-11-11 07:54:31 EDT ---
Just a few comments:

- BR: python-setuptools is enought not -devel
- Could not download the source -> 404, had to unpack the src.rpm
- rpmlint:
  $ rpmlint yum-langpacks.spec yum-langpacks-0.1.3-1.fc11.src.rpm noarch/yum-
  langpacks-0.1.3-1.fc11.noarch.rpm
  yum-langpacks.spec:36: E: hardcoded-library-path in /usr/lib/yum-plugins
  /langpacks.py*
  yum-langpacks.src:36: E: hardcoded-library-path in /usr/lib/yum-plugins
  /langpacks.py*
  yum-langpacks.noarch: W: incoherent-version-in-changelog 0.1.2-1 
  ['0.1.3-1.fc11', '0.1.3-1']
  yum-langpacks.noarch: E: non-executable-script /usr/lib/yum-plugins
  /langpacks.py 0644 /bin/env
  2 packages and 1 specfiles checked; 3 errors, 1 warnings.

  * non-execuatble-script: see
http://fedoraproject.org/wiki/PackagingTricks#Remove_shebang_from_files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.