[Fedora-i18n-bugs] [Bug 536737] Review Request: yum-langpacks - langpacks plugin for yum

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=536737


Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |433512




--- Comment #3 from Jens Petersen <petersen at redhat.com>  2009-11-15 21:29:44 EDT ---
(In reply to comment #1)
> - BR: python-setuptools is enough not -devel

This is my first python package and I believe you,
but what about
http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_using_Setuptools
?

(I "stole" the spec file from yum-presto fwiw;)

So I think the Packaging Guidelines need updating then?

> - Could not download the source -> 404, had to unpack the src.rpm

Thanks - fixed.

>   yum-langpacks.spec:36: E: hardcoded-library-path in /usr/lib/yum-plugins
>   /langpacks.py*
>   yum-langpacks.src:36: E: hardcoded-library-path in /usr/lib/yum-plugins
>   /langpacks.py*

I can use _prefix but I think this is basically correct for yum-plugins.
At least other plugins packages are doing the same thing.

>   yum-langpacks.noarch: W: incoherent-version-in-changelog 0.1.2-1 
>   ['0.1.3-1.fc11', '0.1.3-1']

fixing

>   yum-langpacks.noarch: E: non-executable-script /usr/lib/yum-plugins
>   /langpacks.py 0644 /bin/env

thanks - fixed.


Spec URL: http://petersen.fedorapeople.org/yum-langpacks/yum-langpacks.spec
SRPM URL:
http://petersen.fedorapeople.org/yum-langpacks/yum-langpacks-0.1.4-1.fc12.src.rpm

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1808500

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.