[Fedora-i18n-bugs] [Bug 621242] Review Request: gyp - Generate Your Projects

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621242

--- Comment #2 from Akira TAGOH <tagoh at redhat.com> 2010-08-04 23:00:53 EDT ---
(In reply to comment #1)
> Some notes:
> 
> ! Unneeded macros
>   - You can remove %python_sitearch definition because it is uses nowhere.

It was necessary to build on f12:
https://fedoraproject.org/wiki/Packaging:Python#Macros

> * Release
> --------------------------------------------------------
> Release: 0.1.%{?revision:%{revision}svn}%{?dist}
> --------------------------------------------------------
>   - Well, I guess you meant "0.1%{?revision:.%{revision}svn}%{?dist}"

You're right. fixed.

> 
> * BuildRoot
>   - BuildRoot tag is no longer needed on Fedora and EPEL6:
>     https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

fixed.

> 
> * BR for python
>   - Please specify python2 or python3. ref:
>     https://fedoraproject.org/wiki/Packaging/Python#BuildRequires
> 
>   - Build fails on F-12 without BR: python2-devel:
>     http://koji.fedoraproject.org/koji/taskinfo?taskID=2379955

Okay, fixed.

> * %{__python} setup.py install
>   - Maybe there is only small difference, however I guess we usually
>     add "--skip-build" to "python setup.py install".    

Sure. updated with:
Spec URL: http://tagoh.fedorapeople.org/reviews/gyp/gyp.spec
SRPM URL:
http://tagoh.fedorapeople.org/reviews/gyp/gyp-0.1-0.2.839svn.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.