[Fedora-i18n-bugs] [Bug 619395] Review Request: mozc - Opensourced Google Japanese Input

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619395

--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-08-20 15:42:47 EDT ---
Created attachment 440023
  --> https://bugzilla.redhat.com/attachment.cgi?id=440023
make build.log verbose

Okay. I tried 0.12.434.102-0.1.20100820svn and at least
ibus-mozc seems to work on F-14.

Then:
? Obsoletes:
  - I don't see the need of "Obsoletes: ibus-mozc < 0.11.383.102" for another
    reason. As this srpm creates ibus-mozc subpackage, even if this Obsoletes
    does not exist the upgrade path shouldn't be broken.


* build.log / Fedora specific compilation flags
  - Still we cannot check if Fedora specific compilation flags are honored
    or not from build.log. Would you consider to apply the patch attached
    to show the actual command line on build.log?
    The result with the attached patch applied is:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2414933

* Directory ownership issue
  - The directory %{_datadir}/ibus-mozc/ is not owned by any packages.

* Documents
  - At least some documents indicating license information should be added
    to %doc for main (mozc) binary rpm.
    Would you at least consider to add data/installer/credits_??.html to
    %doc?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.