[Fedora-i18n-bugs] [Bug 619395] Review Request: mozc - Opensourced Google Japanese Input

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619395

--- Comment #9 from Akira TAGOH <tagoh at redhat.com> 2010-08-22 22:27:03 EDT ---
(In reply to comment #8)
> Then:
> ? Obsoletes:
>   - I don't see the need of "Obsoletes: ibus-mozc < 0.11.383.102" for another
>     reason. As this srpm creates ibus-mozc subpackage, even if this Obsoletes
>     does not exist the upgrade path shouldn't be broken.

Okay, I may be confused. let's drop that line then.

> * build.log / Fedora specific compilation flags
>   - Still we cannot check if Fedora specific compilation flags are honored
>     or not from build.log. Would you consider to apply the patch attached
>     to show the actual command line on build.log?
>     The result with the attached patch applied is:
>     http://koji.fedoraproject.org/koji/taskinfo?taskID=2414933

Thanks. that looks nice.

> 
> * Directory ownership issue
>   - The directory %{_datadir}/ibus-mozc/ is not owned by any packages.

Indeed. fixed.

> * Documents
>   - At least some documents indicating license information should be added
>     to %doc for main (mozc) binary rpm.
>     Would you at least consider to add data/installer/credits_??.html to
>     %doc?

Sure. I was thinking of doing that though, it contains the unnecessary license
informations too. I'm not sure if it's good to ship it as is or get rid of the
unnecessary thing or add another one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.