[Fedora-i18n-bugs] [Bug 627088] Review Request: fontik - A Configuration Tool for Font-wise, User-set Fontconfig Rules

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627088

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-08-26 04:54:26 EDT ---
Review:
+ package builds in koji (f15).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2425292
+ rpmlint output for SRPM and for RPM.
fontik.src: W: spelling-error %description -l en_US fontconfig -> configure,
configurative, configuration
fontik.src: W: no-buildroot-tag
fontik.src: W: invalid-url Source0: fontik-8e8cea81d.tar.gz
fontik.x86_64: W: spelling-error %description -l en_US fontconfig -> configure,
configurative, configuration
fontik.x86_64: W: no-manual-page-for-binary fontik
==> All can ne ignored.
+ source files match upstream source
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present which is not needed now.
+ package installed properly.
- Macro use appears rather consistent.
+ Package contains code, not content.
+ no .pc file present.
+ no -devel subpackage
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate

Suggestions:
1) You don't need last 2 sentences in %description. Remove following
" I haven't come across any GUI tool that performs these tasks
with ease. This is an attempt on it."

2) replace /usr with %{_prefix} in make install command. And use everywhere
either $RPM_BUILD_ROOT or %{buildroot}

3) If package is needed only for F-13 and above then you can do following in
spec
   a) %clean not needed
   b) cleaning of buildroot at start of %install also not needed


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.