[Fedora-i18n-bugs] [Bug 603638] Review Request: python-defcon - A set of flexible objects for representing UFO data.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603638

--- Comment #2 from Thomas Spura <tomspur at fedoraproject.org> 2010-07-22 06:18:46 EDT ---
Review:

Good:
- name ok
- source matches upstream: 738f62fea9d78b5225706dc7e1a562be
- latest version packaged
- $ rpmlint ./python-defcon-0.1-1.fc13.src.rpm
noarch/python-defcon-0.1-1.fc13.noarch.rpm 
2 packages and 0 specfiles checked; 0 errors, 0 warnings.



Needswork:
- *** Warning: defcon requires FontTools, see:
    fonttools.sf.net
*** Warning: defcon requires RoboFab, see:
    robofab.com

-> Missing BR: python-robofab and fonttools (last one also R)

- Some tests are failing, does upstream know of this?
  Ran 78 tests in 0.641s
  FAILED (failures=5)

- You could build the documentation and include that into a -doc subpackage.
  (I didn't found it on an upstream website.)

- Are you sure, this is installed correctly?
>From __init__.py:
from defcon.objects.font import Font
  9 from defcon.objects.glyph import Glyph, addRepresentationFactory,
removeRepr    esentationFactory
 10 from defcon.objects.contour import Contour

But there is no defcon.objects. etc installed, just in the source...
It seems python setuptools or the setup.py are wrong. :(

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.