[Fedora-i18n-bugs] [Bug 614329] Review Request: emacs-common-w3m - W3m interface for Emacsen

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614329

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2010-07-26 23:59:54 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2350728
+ rpmlint output for SRPM and for RPM.
emacs-common-w3m.src: W: no-cleaning-of-buildroot %clean
emacs-common-w3m.src: W: no-buildroot-tag
emacs-common-w3m.src: W: no-%clean-section
emacs-common-w3m.src: W: invalid-url Source0: emacs-w3m-1.4.398.tar.gz
emacs-w3m.noarch: W: spelling-error Summary(en_US) elisp -> lisp, e lisp, Elise
emacs-w3m.noarch: W: spelling-error %description -l en_US elisp -> lisp, e
lisp, Elise
emacs-w3m.noarch: W: no-documentation
emacs-w3m-el.noarch: W: spelling-error Summary(en_US) Elisp -> Elis, Lisp,
Elise
emacs-w3m-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e
lisp, Elise
emacs-w3m-el.noarch: W: obsolete-not-provided w3m-el
emacs-w3m-el.noarch: W: no-documentation
xemacs-w3m.noarch: W: spelling-error Summary(en_US) elisp -> lisp, e lisp,
Elise
xemacs-w3m.noarch: W: spelling-error %description -l en_US elisp -> lisp, e
lisp, Elise
xemacs-w3m.noarch: W: no-documentation
xemacs-w3m-el.noarch: W: spelling-error Summary(en_US) Elisp -> Elis, Lisp,
Elise
xemacs-w3m-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e
lisp, Elise
xemacs-w3m-el.noarch: W: obsolete-not-provided w3m-el-xemacs
xemacs-w3m-el.noarch: W: no-documentation
=> These messages can be ignored
emacs-w3m.noarch: W: name-repeated-in-summary C Emacs-w3m
==>This is not a blocker though as its because of following the spec template
for emacs addons.

+ source files match upstream url when packaged according to given steps.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present which is not needed now.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ following emacs packaging guidelines
+ Not a GUI application

Suggestions:
1) use install commands with "install -p" to preserve timestamps 
2)wherever possible use
https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

Please do the above changes before you import this in cvs.
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.