[Fedora-i18n-bugs] [Bug 603629] Review Request: cf-sorts-mill-goudy-fonts - Goudy Oldstyle and Italic fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603629

--- Comment #2 from Pravin Satpute <psatpute at redhat.com> 2010-06-28 10:47:25 EDT ---
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2277636
+ rpmlint is silent for SRPM and for RPM.
cf-sorts-mill-goudy-fonts.src: W: no-buildroot-tag
-> no need for it now

cf-sorts-mill-goudy-fonts.src: W: uncompressed-zip goudy-3.0.zip
-> please check this

cf-sorts-mill-goudy-fonts.noarch: W: obsolete-not-provided
ofl-sorts-mill-goudy-fonts

-> this is ok, since build happen only in devel

+ source files match upstream url
50520a9636ae999f2f72cb2b5f41b147  goudy-3.0.zip

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ fonts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.