[Fedora-i18n-bugs] [Bug 630932] Review Request: ibus-table-others- Various tables for IBus-Table

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630932

--- Comment #9 from Parag AN(पराग) <panemade at gmail.com> 2010-10-19 06:37:03 EDT ---
+ Koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=2542593
+ rpmlint output
ibus-table-cyrillic.noarch: W: spelling-error %description -l en_US rustrad ->
rust rad, rust-rad, frustrated
ibus-table-cyrillic.noarch: W: spelling-error %description -l en_US yawerty ->
yawmeter, QWERTY, qwerty
ibus-table-latin.noarch: W: spelling-error %description -l en_US ipa -> IPA,
pa, nipa
ibus-table-latin.noarch: W: spelling-error %description -l en_US sampa ->
sampan, salpa, pampa
ibus-table-others.src: W: no-buildroot-tag
ibus-table-translit.noarch: W: spelling-error %description -l en_US ua -> ya,
us, u

+ source verified with upstream url as (sha1sum)
a6b347fa2f127911ebe8a1c5752382cb1df1c6b2 
ibus-table-others-1.3.0.20100907.tar.gz
a6b347fa2f127911ebe8a1c5752382cb1df1c6b2 
ibus-table-others-1.3.0.20100907.tar.gz.srpm

Suggestions:
1) drop the following options to %configure
--disable-static, --prefix

2) Drop the cleaning of buildroot in %install, that mean following line
%__rm -rf $RPM_BUILD_ROOT

3) Good not to use macros for make 

4) Drop the %clean section

5) I will suggest dropping %doc from all subpackages as those already requires
main package and adding following
%files
%doc AUTHORS COPYING README

6) Drop the versions from BR: and R: for ibus-table and ibus-table-devel, as we
already used to build the required dependencies in release and then this
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.