[Fedora-i18n-bugs] [Bug 614299] Review Request: python-ordereddict - Py2.7's new collections.OrderedDict that works in Python 2.4-2.6.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614299

Toshio Ernie Kuratomi <a.badger at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |a.badger at gmail.com

--- Comment #2 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2010-10-27 19:19:16 EDT ---
If you could review someone else's package so that I have more to evaluate you
on I'd appreciate it.  Here's a preliminary review:

NEEDSWORK:
* There is an upstream tarball for this at pypi:
  http://pypi.python.org/pypi/ordereddict
  - The tarball in the srpm does not match the tarball on pypi
* We should be sticking to 80 columns or less in spec files.  If the Summary is
longer than 80 columns, chances are that it's too long.
* %define should be changed to %global as %define inside of %{} is only working
due to an rpm bug.

You can reach me on IRC: abadger1999 on freenode.net, email toshio
fedoraproject.org, or just CC me on a review request that you take.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.