[Fedora-i18n-bugs] [Bug 662604] Review Request: ibus-unikey - A Vietnamese engine for IBus input platform that uses Unikey.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662604

--- Comment #11 from Christoph Wickert <cwickert at fedoraproject.org> 2011-02-20 18:15:42 EST ---
I'm incredibly sorry, this completely dropped of my radar. :(

>From a packaging point of view, the package is fine now:
OK - MUST: package meets the Packaging Guidelines
OK - MUST: handles locales properly with %find_lang
OK - MUST: owns all directories that it creates
OK - MUST: package does not own files or directories already owned by other
packages

Some minor notes on the changelog:
- mention version and release
- mention your changes
- use one blank line between al changelog entries

A proper changelog would look like this:
%changelog
* Mon Dec 20 2010 Truong Anh Tuan <tuanta at iwayvietnam.com> - 0.5.1-2
- Fix file and directory ownership (#662604)
- Use %%find_lang macro for locales

* Mon Dec 13 2010 Truong Anh Tuan <tuanta at iwayvietnam.com> - 0.5.1-1
- Initial release 0.5.1 getting from upstream

If you use a macro in a comment/changelog, you need to escape it with a second
%. If you fix a but, add the number at the  More about changelogs can be found
at https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs


I am really sorry I cannot approve this package because it still doesn't build
in Fedora 15. Did you contact the developers and showed them the build.log?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.