[Fedora-i18n-bugs] [Bug 813125] ibus should not generate empty preedit strings on focus switch

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=813125

fujiwara <tfujiwar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(luke.hutch at gmail.
                   |                            |com)

--- Comment #12 from fujiwara <tfujiwar at redhat.com> 2012-04-20 04:16:24 EDT ---
(In reply to comment #10)
> For (1), just select a cell in Gnumeric that contains text, then go to the iBus
> panel applet and switch to another input method while the keyboard focus is
> still on Gnumeric. Gnumeric will enter edit mode with empty preedit text again.
> (Same symptom, different trigger.)
> 
> The RPMs you posted yesterday do fix all three preedit problems on my home
> computer (even though they didn't fix my work computer). I'll try again on the

OK, I cannot reproduce your problem with yesterdays' RPMs.

> work computer tomorrow.  The home computer strace only produces the following
> two messages on gnumeric startup, and nothing subsequently on IM switch etc.:
> 
> stat("/usr/lib64/gtk-2.0/2.10.0/immodules/im-ibus.so", {st_mode=S_IFREG|0755,
> st_size=27520, ...}) = 0
> open("/usr/lib64/gtk-2.0/2.10.0/immodules/im-ibus.so", O_RDONLY|O_CLOEXEC) = 8

Yes, the loading .so files are happened at the first access only.
I asked it because you still saw your problem with the updated RPM and that
im-ibus.so has the fix.

> 
> Since the "preedit-changed" signal is called from many places in ibus, is it
> possible there may be other cases that are calling it at incorrect times, or do
> you think you probably caught them all?

Almost places emit the "preedit-changed" signal when the preedit_visible is
changed so I think you don't see that problem.


(In reply to comment #11)
> Hmm, two more cases that generate empty preedit strings: clicking "Restart" or
> "Quit" on the ibus panel applet while Gnumeric is focused.

Good catch.
I added the check for _ibus_context_destroy_cb() besides
_ibus_context_disabled_cb():
https://github.com/fujiwarat/ibus/commit/5fb8bb0b35549c5ac22382418241ef594e94037b

I created the test RPMs:
http://fujiwara.fedorapeople.org/ibus/20120418/4008321/
Could you try ibus-1.4.1-2.fc16.x86_64.rpm and
ibus-gtk2-1.4.1-2.fc16.x86_64.rpm ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.