[Fedora-i18n-bugs] [Bug 787564] Review Request: fonts-tweak-tool - a GUI tool for customizing fonts per language on desktops using fontconfig.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787564

--- Comment #2 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2012-02-06 19:19:40 EST ---
Some rpmlint issues:

---
rpmlint -i
/home/mohamed/rpmbuild/RPMS/noarch/fonts-tweak-tool-0.0.1-1.fc16.noarch.rpm
fonts-tweak-tool.noarch: W: spelling-error %description -l en_US fontconfig ->
configuration
The value of this tag appears to be misspelled. Please double-check.

fonts-tweak-tool.noarch: E: description-line-too-long C fonts-tweak-tool is a
GUI tool for customizing fonts per language on desktops using fontconfig.
Your description lines must not exceed 80 characters. If a line is exceeding
this number, cut it to fit in two lines.

fonts-tweak-tool.noarch: W: invalid-url URL:
https://github.com/downloads/jamesni/fonts-tweak-tool HTTP Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.

fonts-tweak-tool.noarch: E: incorrect-fsf-address /usr/bin/fonts-tweak-tool
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

fonts-tweak-tool.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/fontstweak/tool.py
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

fonts-tweak-tool.noarch: W: no-manual-page-for-binary fonts-tweak-tool
Each executable in standard binary directories should have a man page.

1 packages and 0 specfiles checked; 3 errors, 3 warnings.
---

You can ignore the spelling issues, they are false positive. You can also skip
the missing man page issue, it's not mandatory to have one. But the other
warnings/errors must be solved:
- I suppose the correct URL is https://github.com/jamesni/fonts-tweak-tool
- since you are the developer of font-tweak-tools, you should really fix the
FSF address in the comments of your source code


Now about the .spec file:

- you don't need anymore to set the %python_sitelib macro, its definition is
now provided by the rpm package:
      http://fedoraproject.org/wiki/Packaging:Python#Macros
- the summary is maybe too mysterious: something like " Tool for customizing
fonts per language" may be more explicit, or any other description, at your
convenience
- the Group tag "Development/Tools" is maybe far from corresponding to your
tool. Something like "User Interface/Desktops" is more appropriate.
- You could really take advantage of macros in the Source0 URL:
      Source0:
https://github.com/downloads/jamesni/fonts-tweak-tool/%{name}-%{version}.tar.gz
- The BuildRoot tag is not needed anymore, as well as cleaning the build root
(occurrences "rm -rf $RPM_BUILD_ROOT" can be dropped):
      http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
- I suggest you to replace "python-setuptools" by "python2-setuptools" in your
BuildRequires, in case Fedora switches to Python 3 by default.
- I don't think the version condition on libeasyfc is necessary, since only
Fedora 16 and Rawhide provide libeasyfc, at version 0.5.
- The %defattr macro is useless now in %files:
   http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
- The %clean target is useless too:
   http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.