[Fedora-i18n-bugs] [Bug 821247] Review Request: fcitx-table-other - Other tables for Fcitx

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=821247

--- Comment #2 from Liang Suilong <liangsuilong at gmail.com> ---
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094937
SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-table-other.spec
SRPM:
http://liangsuilong.fedorapeople.org/fcitx/fcitx-table-other-0.1.0-1.fc16.src.rpm

(In reply to comment #1)
> Review:-
> + koji scratch build for f18 ->
> http://koji.fedoraproject.org/koji/taskinfo?taskID=4074057
> 
> + rpmlint on rpms gave
> fcitx-table-other.src: W: spelling-error %description -l en_US ibus -> ibis,
> bus, i bus
> fcitx-table-other.src: W: strange-permission fcitx-table-other.spec 0775L
> fcitx-table-other.src: W: invalid-url Source0:
> http://fcitx.googlecode.com/files/fcitx-table-other-0.1.0.tar.xz HTTP Error
> 404: Not Found
> fcitx-table-other.noarch: W: spelling-error %description -l en_US ibus ->
> ibis, bus, i bus
> 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
> 
> 
> + Source verified with upstream as (sha1sum)
> e3deab3d66f87321c1b1e71762e5a529eb2b324b 
> ../SOURCES/fcitx-table-other-0.1.0.tar.xz
> e3deab3d66f87321c1b1e71762e5a529eb2b324b  fcitx-table-other-0.1.0.tar.xz
> 
> 
> Suggestions:-
> 1) spec file got strange permissions. use "chmod 644 fcitx-table-other.spec"
> and then build srpm and use it to import in Fedora.

Fixed

> 
> 2) License is not clear. COPYING says GPLv3+ whereas compose and emoji
> tables are LGPLv2+ and LGPL
> and spec then says GPLv2+

I contacted with the author. He said the pacakges is a fork from
ibus-table-others. I checked the spec file of ibus-table-others and it is under
GPLv3. So I think fcitx-table-other is under GPLv3+ is OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/i18n-bugs/attachments/20120522/f64525f8/attachment.html>