[Fedora-i18n-bugs] [Bug 801073] Review Request: kcm-fcitx - KDE Config Module for Fcitx

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=801073

--- Comment #7 from Rex Dieter <rdieter at math.unl.edu> ---
Several suggestions:

1.  replace
cat << EOF > %{name}.lang 
%lang(zh) /usr/share/locale/zh_TW/LC_MESSAGES/kcm_fcitx.mo
%lang(zh) /usr/share/locale/zh_CN/LC_MESSAGES/kcm_fcitx.mo
EOF

with
%find_lang %{name}


2.  in %build

you have
pushd build

but no matching
popd


3.  (cosmetics, but shorter) in %install, replace
pushd build
make install DESTDIR=$RPM_BUILD_ROOT
popd

with
make install  DESTDIR=$RPM_BUILD_ROOT -C build

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/i18n-bugs/attachments/20120522/e61a064c/attachment.html>