Change Request: fix a fas2 vs fas1 regression
Mike McGrath
mmcgrath at redhat.com
Fri May 2 02:54:45 UTC 2008
On Thu, 1 May 2008, Toshio Kuratomi wrote:
> I've just committed this change to the fas git repo that fixes a change in the
> dump format from fas1 to fas2. In fas1, the role_type was accurate when
> dumped from the account system. In fas2, role_type was always "user" even if
> the person was a sponsor or administrator.
>
> I'd like to have this applied to the production FAS so that the Package Status
> Scripts can be run again.
>
> Changes:
> * Correct information which has been inaccurate since migration to FAS2.
> * No longer check if the user is in the group their trying to dump as they
> can retrieve the information by retrieving the list of all users anyway.
> * Speed up dumping when a groupname is specified (probably significantly on
> app5) by making a single database query per call instead of one db query per
> user in the group.
>
> Risk:
> * FAS is a major service. Many third-party apps consume this particular
> page as it's an easy way for them to get username=>email mappings.
> * This adds a field to the data as retrieved via json. It adds a field for
> role_type of the user to each record.
>
> Mitigation:
> * The format of the page isn't changing, just the accuracy of one of the
> fields.
> * The patch is very small and limited to this single method and one line in
> its template.
> * Tested when group name is unspecified, group name is specified, and
> whether retrieving json or plain text.
>
> Benefits:
> * Allows Package Status Scripts to run once again
> * Speedier
>
+1. I'm familiar with this bug and completely forgot about it. Sorry
bout that.
-Mike
More information about the infrastructure
mailing list