[PATCH] add IPv6 addresses for apache VirtualHost stanzas

[Jeff Garzik]

On 08/28/2009 07:36 PM, Mike McGrath wrote:
> On Fri, 28 Aug 2009, Jeff Garzik wrote:
>
>> On 08/28/2009 05:11 PM, Matt Domsch wrote:
>>> From: Matt Domsch<mdomsch at puppet1.fedora.phx.redhat.com>
>>>
>>> ---
>>>    manifests/servergroups/proxy.pp |   23 +++++++++++++++++++++++
>>>    1 files changed, 23 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/manifests/servergroups/proxy.pp
>>> b/manifests/servergroups/proxy.pp
>>> index bfa0481..eeb9e19 100644
>>> --- a/manifests/servergroups/proxy.pp
>>> +++ b/manifests/servergroups/proxy.pp
>>> @@ -22,6 +22,7 @@ class proxy {
>>>                "66.35.62.162",
>>>                "80.239.156.214",
>>>                "152.46.7.221",
>>> +            "[2610:28:200:1::fed0:1]",
>>>            ],
>>>            server_aliases =>   [ "stg.fedoraproject.org" ],
>>>            ssl            =>   true,
>>
>> No objection/comment on the IPv6 portion of this patch.
>>
>> I'm surprised these highly repetitive address lists are not auto-generated
>> from a flat file (or other database), though.
>>
>
> I'm not quite sure what you mean but I am interested in a better way to do
> this.  basically we've got 4 sites + staging.  As such, fedoraproject.org
> could listen on 5 different addresses.  We have to enter them somewhere,
> any ideas?

I was thinking in the m4-macro sense; looking at Matt's patch, it 
appears that a large number of virtual hosts have the same address list. 
  If so, it seems like some sort of macro substitution could be employed 
to match a list of virtual hosts with a set of addresses.

Not a big deal... just noting an above-average amount of copy/paste.

	Jeff