[puppet: 1/2] Adding memcached selinux policy"

[brett lentz]

Why not just do this:

if $memcached_maxconn { $maxconn = $memcached_maxconn } else {
$maxconn = 1024 }


That's much more clear about what conditions set the default value.

---Brett.


On Tue, Sep 22, 2009 at 9:55 AM, Darren VanBuren <onekopaka at gmail.com> wrote:
> I only saw the "$maxconn = $memcached_maxconn ? {       ""      => "1024",•
>
> Still, that's some funky syntax.
>
> Darren VanBuren
> -------------------------
> Sent from my iPod
>
> Try Fedora 10 today. Fire it up. http://fedoraproject.org/
>
> On Sep 22, 2009, at 8:47, Mike McGrath <mmcgrath at redhat.com> wrote:
>
>> On Tue, 22 Sep 2009, Darren VanBuren wrote:
>>
>>> Why is maxconn an array? Seems like a waste to me.
>>>
>>
>> It's not, maxconn is a string, but in the syntax we're using:
>>
>>   $maxconn = $memcached_maxconn ? {
>>       ""      => "1024",
>>       default => $memcached_maxconn
>>   }
>>
>>
>> We have it set to a default value.
>>
>>   -Mike
>>
>>> Darren VanBuren
>>> -------------------------
>>> Sent from my iPod
>>>
>>> Try Fedora 10 today. Fire it up. http://fedoraproject.org/
>>>
>>> On Sep 22, 2009, at 7:38, Mike McGrath <mmcgrath at fedoraproject.org>
>>> wrote:
>>>
>>>> commit 5b943443066594955fb0194d65524dff4e5ad468
>>>> Author: Mike McGrath <mmcgrath at redhat.com>
>>>> Date:   Tue Sep 22 09:38:19 2009 -0500
>>>>
>>>>  Adding memcached selinux policy"
>>>>
>>>> modules/memcached/manifests/init.pp |    1 +
>>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>> ---
>>>> diff --git a/modules/memcached/manifests/init.pp
>>>> b/modules/memcached/manifests/init.pp
>>>> index bea2842..cdf5911 100644
>>>> --- a/modules/memcached/manifests/init.pp
>>>> +++ b/modules/memcached/manifests/init.pp
>>>> @@ -1,5 +1,6 @@
>>>> class memcached {
>>>>  package { memcached: ensure => present }
>>>> +    package { memcached-selinux: ensure => present }
>>>>
>>>>  $maxconn = $memcached_maxconn ? {
>>>>      ""      => "1024",
>>>
>>> _______________________________________________
>>> Fedora-infrastructure-list mailing list
>>> Fedora-infrastructure-list at redhat.com
>>> https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
>>
>> _______________________________________________
>> Fedora-infrastructure-list mailing list
>> Fedora-infrastructure-list at redhat.com
>> https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
>
> _______________________________________________
> Fedora-infrastructure-list mailing list
> Fedora-infrastructure-list at redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
>