[PATCH/RFC] func: Simplify minion.conf creation

seth vidal skvidal at fedoraproject.org
Mon Aug 30 14:52:12 UTC 2010


On Sun, 2010-08-29 at 12:23 -0400, Todd Zullinger wrote:
> Puppet conveniently makes most variables from Puppet.settings available
> via Puppet[:variable].  Use this to generate minion.conf via a standard
> ERB template.
> ---
> 
> This change is the sort of thing that really begs for a second set of
> eyes, as it would cause too much trouble if it didn't work as
> intended.
> 

Which makes me ask - why change it?

We know it works now..


I don't see anything wrong with what you have but I'm not clear on why
an ERB template is better.

-sv




More information about the infrastructure mailing list