[PATCH/RFC] func: Simplify minion.conf creation

[Todd Zullinger]

seth vidal wrote:
> Which makes me ask - why change it?
>
> We know it works now..
>
>
> I don't see anything wrong with what you have but I'm not clear on
> why an ERB template is better.

As a general code cleanup.  Forking 3 shells to ruby to get data
provided by puppet directly is less efficient and uglier than using a
standard template.  Also, while I don't imagine it will change anytime
soon, but if the puppet code gets reorganized in the future, I can see
the current ruby shell queries being broken more easily than accessing
the variables via puppet.

But it's not a big deal if you think it's not worth the risk to clean
it up.

Perhaps add a note there that the variables are available, so others
perusing the puppet manifests don't think they need to resort to this
sort of thing for other tasks?  A lot of folks don't spend their days
in puppet manifests and learn from reading the other code in the
repository.

(I've been called a pedant before though.  Shocking, I know. ;)

-- 
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I believe in the noble, aristocratic art of doing absolutely nothing.
And someday, I hope to be in a position where I can do even less.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 542 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/infrastructure/attachments/20100830/08376eb0/attachment-0001.bin