[PATCH][bodhi] Fix a bug in our masher sanity check

Ricky Zhou ricky at fedoraproject.org
Wed Oct 27 16:50:50 UTC 2010


On 2010-10-27 12:42:04 PM, Luke Macken wrote:
> There is a bug in bodhi's new pre-push sanity checker that causes the
> mashing lockfile to get wiped out when a push is resumed and the sanity
> check fails.
> 
> I would like to push this patch out to releng2 and relepel01 only.
> 
> --- a/bodhi/masher.py
> +++ b/bodhi/masher.py
> @@ -641,7 +641,6 @@ class MashTask(Thread):
>              if self.resume:
>                  if not self.safe_to_resume():
>                      log.error("safe_to_resume failed! -- aborting")
> -                    self._unlock()
>                      masher.done(self)
>                      return
>              else:
+1

Thanks,
Ricky
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/infrastructure/attachments/20101027/c3b9b0ea/attachment.bin 


More information about the infrastructure mailing list