[PATCH/RFC] func: Simplify minion.conf creation
seth vidal
skvidal at fedoraproject.org
Fri Sep 3 15:23:06 UTC 2010
On Mon, 2010-08-30 at 11:28 -0400, seth vidal wrote:
> On Mon, 2010-08-30 at 11:22 -0400, Todd Zullinger wrote:
> > As a general code cleanup. Forking 3 shells to ruby to get data
> > provided by puppet directly is less efficient and uglier than using a
> > standard template. Also, while I don't imagine it will change anytime
> > soon, but if the puppet code gets reorganized in the future, I can see
> > the current ruby shell queries being broken more easily than accessing
> > the variables via puppet.
>
> That's a fair explanation.
>
> Doing it b/c the puppet folks are more likely to break a relative
> edge-case is reasonable.
>
> doing it b/c it is more puppet-y just irks me.
>
okay - I've found a usecase for this, now.
bxen04 was renamed from another name - the make-minion-conf never got
reran so func was just not working.. If it was a thing in puppet it
would have been working.
so... seems like your recommendation is a good one.
thanks,
-sv
More information about the infrastructure
mailing list