[PATCH 2/2] templatize rsyncd.conf for master mirrors

[seth vidal]

On Wed, 2011-07-06 at 11:12 -0500, Matt Domsch wrote:

> What we have now is awful.  edit rsyncd.conf.download0 in 2 places.
> Copy that file to rsyncd.conf.download0[2345] and
> rsyncd.conf.download-rdu0[123].  Commit same change to all files.
> 
> 
> Could do $group_of_some_kind w/o templates I suppose.  Still leaves
> the editing in 2 places (which I've forgotten to do the second one as
> recently as yesterday) though.  The template makes that one edit.

one edit which can break places you didn't intend.

It's the fundamental problem with our templates we end up not knowing
what else is going to be impacted by the changes.

Our current rsyncd.* layout is not good, I agree. but this is why we
have

$datacenter
$hostname
$arbitrary_variable_we_can_use

and give those in any order we want for the source list for the files.

I'm strongly against using the templates.

I'd rather have a set of files I can more easily grep for the changes
than have to know what the template definition might include from
elsewhere.

-sv