[PATCH] hosted: Remove gzip encoding for .gz*.asc files in apache config

Todd Zullinger tmz at pobox.com
Wed Jul 27 19:40:44 UTC 2011


It was reported that various browsers were giving errors when attempting
to download the .asc file for func-0.28¹.  The reason appears to be that
the func .asc file did not match the simple *.gz.asc pattern used to
remove the .gz encoding.

Using FilesMatch should be more reliable.  Arguably, we could just use
*.asc here as well.

¹ https://www.redhat.com/archives/func-list/2011-July/msg00017.html
---

I know hosted isn't in a freeze at the moment, but I thought I'd check
before committing this change.  I'd have just changed the pattern to
*.asc, but I wasn't sure whether httpd would take issue to a
RemoveEncoding call on files that lacked it previously.

Anyone see a problem with this fix or the simpler one to continue
using <Files> and just changing the pattern to *.asc?  (I'd fix the
mis-cased </files> then too.)

 configs/web/fedorahosted.org.conf |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configs/web/fedorahosted.org.conf b/configs/web/fedorahosted.org.conf
index 44c0597..b300f7c 100644
--- a/configs/web/fedorahosted.org.conf
+++ b/configs/web/fedorahosted.org.conf
@@ -11,9 +11,9 @@ Listen 443
     ServerName fedorahosted.org
     ServerAdmin webmaster at fedoraproject.org
 
-    <Files *.gz.asc>
+    <FilesMatch "\.gz.*\.asc$">
         RemoveEncoding .gz
-    </files>
+    </FilesMatch>
 
     Alias /robots.txt /srv/web/fedorahosted.org/robots.txt
 
-- 
1.7.6

-- 
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Even celibacy isn't a 100% fool proof way to avoid pregnancy... just
ask the Virgin Mary.



More information about the infrastructure mailing list