Review app for Fedora

[Pierre-Yves Chibon]

On Tue, 2011-11-29 at 13:18 -0700, Kevin Fenzi wrote:
> On Tue, 29 Nov 2011 14:51:39 +0100
> Pierre-Yves Chibon <pingou at pingoured.fr> wrote:
> 
> > Hi,
> > 
> > With the work recently done on fedora-review [1], I started to wonder
> > if it would be interesting to work on an app dedicated to review RPM
> > package for Fedora.
> > 
> > I got myself day dreaming about:
> ...snip...
> 
> So, the advantages would be: 
> 
> - Could run the review tool on the package whenever it updated. 
> - git history could be kept. 
> - Could possibly require some level of completness before filing the
>   review. 
> 
> Disadvantages would be: 
> 
> - Another service/code we need to maintain. 
> - Possibly having to deal with junk uploads unless we filter things
>   well. 
> 
> Any others? 

What's your overall feeling? Positive/negative ? 

> > I was wondering if it could rely on a similar infrastructure than what
> > we are using via fedpkg/pyrpkg (a reviewpkg ?).
> 
> Possibly. I would personally not want to see this on the same
> server/setup as real packages, just to be sure there would be no
> leakage from these into real packages somehow. 
> 
> But some kind of similar instance could be setup I suppose. 

That was my idea yes.

> > I was curious if that would be interesting and since an example is
> > worth many words, I tried to work on a small proof of concept [2]. The
> > README.txt contains the information on how to set it up for testing.
> > It needs still a lot of changes:
> > - All parts regarding the review itself (changing the status, adding
> > one in cc, mail comments added...) is to be done
> 
> It makes me wonder if we couldn't just ditch bugzilla entirely if we
> move to this? have comments and such in the app... 

That was also my idea, move all package review to this.

Thanks for your feedback.

Pierre