Freeze break for post-update hook on pkgs01?

[Ralph Bean]

When we were adding the fedmsg hooks to pkgs01 and pkgs01.stg, we decided it
would be a nice "extra" to run "git update server-info" on each repo for each
push.  This made cloning via http possible.

We ran a script "git check-perms /srv/git/rpms --check=post-update --fix" on
pkgs01 that added this hook for every repo, but I forgot to add it to
"setup_git_package" so that it would be added for every new repo.  Now there
are a handful of repos that do not have the hook, while most others do.

Other than the inconsistency, this doesn't matter all too much.  It is
annoying, however, due to a cron job that is checking for the new hook,
failing to find it, and bothering sysadmins about it over email.

I'm seeking +1s for a freeze break to make the following two changes:

  1) Run "git check-perms /srv/git/rpms --check=post-update --fix" on pkgs01
     again to fix the handful of repos that are out of sync.

  2) Apply the following patch in puppet which will add the hook for new repos.

diff --git a/modules/gitolite/files/distgit/setup_git_package b/modules/gitolite/files/distgit/setup_git_package
index bd42b95..eeaa16f 100755
--- a/modules/gitolite/files/distgit/setup_git_package
+++ b/modules/gitolite/files/distgit/setup_git_package
@@ -121,6 +121,9 @@ ln -s /usr/share/git-core/post-receive-fedmsg \
 ln -s /usr/share/git-core/post-receive-chained \
     $GITROOT/$PACKAGE.git/hooks/post-receive
 
+# This executes "git update-server-info" on each push for clone via http
+ln -s /usr/share/git-core/templates/hooks/post-update.sample \
+    $GITROOT/$PACKAGE.git/hooks/post-update
 
 rm -rf $TMPDIR
 echo "Done."