[Freeze Break Request] Remove extraneous notify on /etc/sysconfig/puppet

Kevin Fenzi kevin at scrye.com
Fri Sep 14 02:58:39 UTC 2012


On Fri, 14 Sep 2012 02:54:45 +0000
Jon Stanley <jonstanley at gmail.com> wrote:

> Since we're not using the puppet agent anymore, if
> the /etc/sysconfig/puppet file is changed, there is no need to notify
> the puppet service. At best, this would be a no-op, and at worst it
> would start the agent, which we don't want.
> ---
>  modules/puppet/manifests/init.pp |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/modules/puppet/manifests/init.pp
> b/modules/puppet/manifests/init.pp index c04f2e1..bd016aa 100644
> --- a/modules/puppet/manifests/init.pp
> +++ b/modules/puppet/manifests/init.pp
> @@ -31,7 +31,6 @@ class puppet::client {
>  
>      file { "/etc/sysconfig/puppet":
>          source  => "puppet:///puppet/puppet.sysconfig",
> -        notify  => Service["puppet"],
>          require => Package["puppet"],
>      }
>      file { "/usr/local/bin/run-puppet":

Sure, seems a simple and easy fix. +1

kevin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.fedoraproject.org/pipermail/infrastructure/attachments/20120913/86265ebc/attachment.sig>


More information about the infrastructure mailing list