Change request: fix a bug in signing the fpca

Toshio Kuratomi a.badger at gmail.com
Fri Apr 19 20:12:29 UTC 2013


Today a bug was reported in fas.  Symptoms are the first time someone trie to
sign the FPCA it fails.  A subsequent attempt will succeed.  The reason is a typo
in one code path through the fpca signing process.  The fix is a simple
correction of the typo and should be easy to revert if it causes unexpected
problems.

May I get two +1's to apply this as a hotfix?


diff --git a/fas/fpca.py b/fas/fpca.py
index 198a1c6..7cf6a9c 100644
--- a/fas/fpca.py
+++ b/fas/fpca.py
@@ -338,7 +338,7 @@ def send(self, human_name, telephone, country_code, postal_address=None,
             person.apply(group, person) # Apply for the new group
             session.flush()
 
-            fas.fas.fedmsgshimshim.send_message(topic="group.member.apply", msg={
+            fas.fedmsgshim.send_message(topic="group.member.apply", msg={
                 'agent': person.username,
                 'user': person.username,
                 'group': group.name,
-- 
1.8.1.6


-Toshio
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.fedoraproject.org/pipermail/infrastructure/attachments/20130419/11ccf53f/attachment.sig>


More information about the infrastructure mailing list