Freeze Break Request: Add collectd monitoring for memcached

[Pierre-Yves Chibon]

On Wed, Nov 19, 2014 at 09:43:58AM -0500, Ralph Bean wrote:
> Hi all-
> 
> Memcached has been locking up on us lately.  If I remember correctly
> it was Saturday morning, then again Monday morning, and it did it
> again today (which manifested in a badges.fedoraproject.org outage for
> users).
> 
> We currently don't have any collectd monitoring directly on memcached.
> Here's an ansible patch that should add it.  Since we're in freeze,
> this would need two +1s in order to be able to be applied.
> 
> If, for some reason it was broken or hosed up, I could revert it by
> removing the /etc/collectd.d/memcached.conf file on both memcached
> servers and subsequently restarting the memcached daemon.
> 
> Patch follows:
> 
> From 6535e0344f4db5b0eb00aeb37007c92f471d7224 Mon Sep 17 00:00:00 2001
> From: Ralph Bean <rbean at redhat.com>
> Date: Wed, 19 Nov 2014 14:37:50 +0000
> Subject: [PATCH] Add collectd monitoring for the memcached daemon.
> 
> ---
>  playbooks/groups/memcached.yml                |    1 +
>  roles/collectd/memcached/files/memcached.conf |    6 ++++++
>  roles/collectd/memcached/tasks/main.yml       |    8 ++++++++
>  3 files changed, 15 insertions(+), 0 deletions(-)
>  create mode 100644 roles/collectd/memcached/files/memcached.conf
>  create mode 100644 roles/collectd/memcached/tasks/main.yml
> 
> diff --git a/playbooks/groups/memcached.yml b/playbooks/groups/memcached.yml
> index 5fc955b..90d52b0 100644
> --- a/playbooks/groups/memcached.yml
> +++ b/playbooks/groups/memcached.yml
> @@ -31,6 +31,7 @@
>    - hosts
>    - fas_client
>    - collectd/base
> +  - collectd/memcached
>    - sudo
>    - memcached
>  
> diff --git a/roles/collectd/memcached/files/memcached.conf b/roles/collectd/memcached/files/memcached.conf
> new file mode 100644
> index 0000000..d59815b
> --- /dev/null
> +++ b/roles/collectd/memcached/files/memcached.conf
> @@ -0,0 +1,6 @@
> +LoadPlugin memcached
> +
> +<Plugin memcached>
> +    Host "localhost"
> +    Port "11211"
> +</Plugin>
> diff --git a/roles/collectd/memcached/tasks/main.yml b/roles/collectd/memcached/tasks/main.yml
> new file mode 100644
> index 0000000..3023af7
> --- /dev/null
> +++ b/roles/collectd/memcached/tasks/main.yml
> @@ -0,0 +1,8 @@
> +---
> +
> +- name: Copy in the memcached collectd config
> +  copy: src=memcached.conf dest=/etc/collectd.d/memcached.conf
> +  tags:
> +  - collectd
> +  - memcached
> +  notify: restart collectd


Looks fine to me and easy to revert in the worst case.

+1

Pierre
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.fedoraproject.org/pipermail/infrastructure/attachments/20141119/4ebfbab0/attachment.sig>