[freeze break request] Make resolv.conf get installed before packages are installed in base.

Ricky Elrod codeblock at elrod.me
Wed Oct 22 00:30:18 UTC 2014


In ansible's base role, we install packages before setting resolv.conf.
But if resolv.conf isn't set, DNS queries don't necessarily work (e.g.
when setting up a new virthost for the first time).

This patch moves the resolv.conf task up to the top of the base role to
ensure it's in place before we do anything requiring DNS lookups.

+1's?

-Ricky

diff --git a/roles/base/tasks/main.yml b/roles/base/tasks/main.yml
index 3b71e9c..7af5095 100644
--- a/roles/base/tasks/main.yml
+++ b/roles/base/tasks/main.yml
@@ -4,6 +4,21 @@
 # This is the base role for all machines.
 # Things in here are things we want to do to every machine no matter what.
 #
+
+# XXX fixme # a datacenter 'fact' from setup
+- name: /etc/resolv.conf
+  copy: src={{ item }} dest=/etc/resolv.conf
+  with_first_found:
+  - "{{ resolvconf }}"
+  - resolv.conf/{{ ansible_fqdn }}
+  - resolv.conf/{{ host_group }}
+  - resolv.conf/{{ datacenter }}
+  - resolv.conf/resolv.conf
+  tags:
+  - config
+  - resolvconf
+  - base
+
 - name: global default packages to install
   yum: state=installed name={{ item }}
   with_items:
@@ -111,20 +126,6 @@
   - config
   - base

-# XXX fixme # a datacenter 'fact' from setup
-- name: /etc/resolv.conf
-  copy: src={{ item }} dest=/etc/resolv.conf
-  with_first_found:
-  - "{{ resolvconf }}"
-  - resolv.conf/{{ ansible_fqdn }}
-  - resolv.conf/{{ host_group }}
-  - resolv.conf/{{ datacenter }}
-  - resolv.conf/resolv.conf
-  tags:
-  - config
-  - resolvconf
-  - base
-
 - name: rsyslog.conf
   copy: src={{ item }} dest=/etc/rsyslog.conf mode=644
   with_first_found:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.fedoraproject.org/pipermail/infrastructure/attachments/20141021/2f7efadd/attachment.sig>


More information about the infrastructure mailing list