Freeze break request: blockerbugs bugfix to correctly sync updates

Pierre-Yves Chibon pingou at pingoured.fr
Tue Sep 9 15:27:47 UTC 2014


On Tue, Sep 09, 2014 at 08:58:58AM -0600, Tim Flink wrote:
> + at api_v0.route('/milestones/current')
> +def get_current_milestone():
> +    current_milestone = get_or_404(Milestone, current=True)
> +    return JsonResponse(current_milestone.simple())

> -    def sync(self, updateinfo, milestone):
> +    def sync(self, updateinfo, fullsync=False):

>      @classmethod
> -    def from_data(cls, updateinfo, release, milestone):
> +    def from_data(cls, updateinfo, release):

These are the two places which scare me a little since you are replacing an
argument with another.

So assuming you have checked that the function calls were updated everywhere to
the new behavior/arguments, +1 for me.


Pierre
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.fedoraproject.org/pipermail/infrastructure/attachments/20140909/06087be6/attachment.sig>


More information about the infrastructure mailing list