Freeze break request: minor change to host ordering priorities

Pierre-Yves Chibon pingou at pingoured.fr
Wed Jul 29 16:29:14 UTC 2015


On Wed, Jul 29, 2015 at 05:24:46PM +0100, Peter Robinson wrote:
> When building ppc builders which reside on qa.fedoraproject.org we get
> the wrong /etc/hosts file because the generic ansible_domain executes
> before the more specific due to task host_group option.
> 
> In general I believe if we have something explicitly in a host_group
> we'd want to prioritise that over a generic sub domain.
> 
> Peter
> 
> diff --git a/roles/hosts/tasks/main.yml b/roles/hosts/tasks/main.yml
> index faeccb9..c74827e 100644
> --- a/roles/hosts/tasks/main.yml
> +++ b/roles/hosts/tasks/main.yml
> @@ -16,9 +16,9 @@
>      - "{{ inventory_hostname }}-hosts"
>      - "{{ ansible_fqdn }}-hosts"
>      - "{{ ansible_hostname }}-hosts"
> +    - "{{ host_group }}-hosts"
>      - "{{ ansible_domain }}-hosts"
>      - "{{ datacenter }}-hosts"
> -    - "{{ host_group }}-hosts"
>      skip: true
>    tags:
>    - config

Sounds ok to me, do we have a way to check which hosts are impacted by this
change?


Pierre


More information about the infrastructure mailing list