[PATCH] distgit: Upload files to both the new and old path
kevin at scrye.com
Thu Jun 4 15:38:13 UTC 2015
On Thu, 04 Jun 2015 14:35:42 +0200
Mathieu Bridon <bochecha at fedoraproject.org> wrote:
> On Fri, 2015-05-29 at 11:56 -0700, Toshio Kuratomi wrote:
> > On Fri, May 29, 2015 at 12:43:32PM +0200, Mathieu Bridon wrote:
> > > If everybody agrees this is the desired behaviour, can we deploy
> > > it in production?
> This had been deployed in production, which took me a bit by surprise
> as this discussion didn't seem to have been finished.
Sorry, this was likely caused by my running the master playbook over
all hosts after our reboots.
However, the expectation should be that when you commit something to
ansible git you expect it to be pushed out and live. If you don't want
something live, do not yet push it into git, or make sure if you want
only staging to add a 'when' for that.
> It caused a bit of a stir due to SELinux (it was disabled in staging
> when I tested those changes), but we fixed it with Pierre-Yves:
Thanks for the quick work on that. Appreciated. ;)
> > Can we avoid the reupload? Hopefully it won't hit too many people
> > (because they'll remember when they have a tarball already
> > uploaded) but it can be painful to wait for something to upload
> > again if it's not needed.
> The same script handles both:
> * checking if a file exists
> * uploading a file
> When it's called with the upload, we can't do much in the script to
> avoid a reupload, it's just going to be reuploaded, and as such the
> behaviour I described in my previous email will ensure we end up with
> the two copies linked to each other.
> However, we could avoid the reupload in normal cases (i.e "fedpkg
> upload" and "fedpkg new-sources") because pyrpkg always checks if the
> file exists (calling the CGI script) before uploading it.
> So we could make the "check" portion of the code verify if the file is
> present either in the old or new location, and if it's found only in
> the old one, symlink it to the new one.
> If that makes sense, I'll cook up a patch (and test it with SELinux
> enforcing in staging, this time ;) )
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 819 bytes
Desc: OpenPGP digital signature
More information about the infrastructure