macrofied kernel.spec

[Jarod Wilson]

Dave Jones wrote:
> On Tue, Jul 31, 2007 at 07:11:05PM -0700, Roland McGrath wrote:
>  > I've verified that this is a no-op vs the 0.61 build.  i.e., it
>  > generates rpms with the same files and same rpm magic, modulo a few
>  > typo fixes and cosmetic cleanups/consolidation of rpm script fragments.
>  > 
>  > In the absence of frothing vitriol, I will commit this after
>  > f8-test1 has sailed.
> 
> My initial reaction was one of shock, but this could just be
> reaction to the sheer size of the diff.  I'll take a look at
> the post-application specfile later.

I've been intending to do the same. Definitely nice to nuke a bunch of
the duplication, but at least in patch form, its not the easiest thing
to read and fully comprehend.

> I've no real fundamental objection to this, but don't leave the country
> or have any accidents for a while after it goes in :-)

Indeed, quite some deep-dark-big-bad-voodoo-daddy macro stuff in there
to wrap one's head around before trying to make any changes.

> Just as when Jarod did the versioning overhaul, if something goes awry,
> you'd probably be able to figure out the problem quicker than those
> getting up to speed on what you've done so far.

Yeah, I thought some of the stuff I did was a bit crazy looking and
invasive... This one definitely takes the cake!

Okay, spent a while looking at a patched spec file. I think I mostly
grok everything, though some of the magic I'm not sure I've ever seen
before. I might even feel comfortable trying to fix things iff Roland
does leave the country or have an accident... ;)

-- 
Jarod Wilson
jwilson at redhat.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
Url : http://lists.fedoraproject.org/pipermail/kernel/attachments/20070801/7b8e3451/attachment.bin