[PATCH] kernel.spec: adding --with firmware & --without vdso_install build options

[Chuck Ebbert]

Kyle McMartin wrote:
> On Tue, Aug 05, 2008 at 11:01:17AM -0400, Jarod Wilson wrote:
>> On Tuesday 05 August 2008 09:24:10 Steve Dickson wrote:
>>> Chuck Ebbert wrote:
>>>> Steve Dickson wrote:
>>>>> Now that devel kernels rpms require the kernel-firmware rpm, it makes
>>>>> sense to me that one should be able to build both of them at the same
>>>>> time. So this patch adds the "--with firmware" build option
>>>>> which will allow kernel-firmware rpms to built with kernel rpms.
>>>>>
>>>>> This patch also adds the "--without vdso_install" build option
>>>>> which stop the VDSO binaries from being installed. This cuts
>>>>> down the overall build time especially when you build over NFS
>>>>> like I do..
>>>>> Signed-Off-By: Steve Dickson <steved at redhat.com>
>>>> With one small change we can still support --without firmware. That way
>>>> the default behavior can be overridden in either case. See below...
>>> Sure.. that works... Is there an ETA for these two changes?
>> I don't quite follow how the firmware change is supposed to work... The 
>> firmware is currently supposed to be a noarch package, and it gets built in 
>> the same pass as the kernel-docs sub-package, so it *shouldn't* be built in 
>> the same pass as the kernel. Is this flag to simply override that and build 
>> the firmware as an arch-specific package for simplified one-off builds?
>>
> 
> You bring up a pretty good point here Jarod, what happens with firmware
> for arch-specific drivers? The Makefile rules will have to be written in
> such a way that it gets built into the package despite the CONFIG_*
> symbol being unset on the build arch.
> 

That's what it does. It includes all firmware, even for drivers that don't get
built. Look in firmware/Makefile and you'll see it builds lists
named fw-shipped-y, fw-shipped-m and fw-shipped- then just merges them to
create fw-shipped-all  which it uses to build/install the firmware.