[Bug 225969] Merge Review: kernel

[Hans de Goede]

Hi,

On 10/26/2010 08:10 PM, Dave Jones wrote:
>
> Spot went through this bug that has been around forever, and wrote up
> some review comments.  I cleaned up some of the low hanging fruit, but
> there's still a few that I'm uncertain on.  input welcomed.
>

<snip>
>   >  kernel.x86_64: W: no-documentation
>   >
>   >  (At a minimum, COPYING should be present as %doc with the GPLv2 terms.)
>
> I'm not sure this makes sense when we have a kernel-doc package.
> Though I note we don't have COPYING in there either.

Well, given that kernel-doc is not a dependency of the kernel itself
(so the kernel can be installed without kernel-doc), having COPYING inside
kernel-doc does not help. A package MUST either ship its license text as
%doc, or require a package which does (ie a foo-devel which requires foo,
does not need to ship its license text as foo already does).

So all kernel (sub) packages must include COPYING unless they require the
main kernel package (and that included COPYING), also see:

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines
Esp. the following section:

   Subpackage Licensing

   If a subpackage is dependent (either implicitly or explicitly) upon a
   base package (where a base package is defined as a resulting binary
   package from the same source RPM which contains the appropriate
   license texts as %doc), it is not necessary for that subpackage to
   also include those license texts as %doc.

   However, if a subpackage is independent of any base package (it does
   not require it, either implicitly or explicitly), it must include
   copies of any license texts (as present in the source) which are
   applicable to the files contained within the subpackage.

********

More over in general packages with a -doc subpackage include the
basic docs in the main package and more extensive docs in the
-doc package, so looking at the kernel source tree, it would seem
that COPYING, CREDITS, MAINTAINERS, README and REPORTING-BUGS
all should be in the main package %doc.

Although maybe we should not include REPORTING-BUGS, assuming that
we want Fedora users to always go through Fedora bugzilla rather then
directly report upstream.

Regards,

Hans