[PATCH] mac80211: fix work removal on deauth request

[Josh Boyer]

On Thu, Jan 19, 2012 at 11:45:29AM +0100, Stanislaw Gruszka wrote:
> From: Johannes Berg <johannes.berg at intel.com>
> 
> When deauth is requested while an auth or assoc
> work item is in progress, we currently delete it
> without regard for any state it might need to
> clean up. Fix it by cleaning up for those items.
> 
> In the case Pontus found, the problem manifested
> itself as such:
> 
> authenticate with 00:23:69:aa:dd:7b (try 1)
> authenticated
> failed to insert Dummy STA entry for the AP (error -17)
> deauthenticating from 00:23:69:aa:dd:7b by local choice (reason=2)
> 
> It could also happen differently if the driver
> uses the tx_sync callback.
> 
> We can't just call the ->done() method of the work
> items because that will lock up due to the locking
> in cfg80211. This fix isn't very clean, but that
> seems acceptable since I have patches pending to
> remove this code completely.
> 
> Reported-by: Pontus Fuchs <pontus.fuchs at gmail.com>
> Tested-by: Pontus Fuchs <pontus.fuchs at gmail.com>
> Signed-off-by: Johannes Berg <johannes.berg at intel.com>
> ---
> Johannes pointed me on IRC that we should apply this patch, it fix
> problem on http://forums.fedoraforum.org/showthread.php?t=275216
> We can also wait until it lend in stable ...

It's not queued for 3.2.2, so we'd be waiting until 3.2.3 probably.
I'll defer to you and John on whether we want to apply it or not but I'd
say sure.  If so, let me know which releases (I'm guessing all).

josh